Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Crash with babel-eslint #273

Merged
merged 5 commits into from
Dec 17, 2017
Merged

Conversation

mysticatea
Copy link
Member

Fixes #213.

It intended to show the message "Use the latest vue-eslint-parser", but it crashes.

This PR fixes the crash and adds tests to check that rules don't crash with babel-eslint.

@mysticatea
Copy link
Member Author

mysticatea commented Dec 2, 2017

Hmmm, it requires eslint@4 because to use require('eslint').Linter API. Old API was deprecated. But eslint-plugin-vue-libs depends on too old ESLint. Can we change to another config? E.g. eslint-config-standard, or eslint-config-eslint.

@michalsnik
Copy link
Member

Thanks for fixing this! Maybe we can update https://github.com/vuejs/eslint-plugin-vue-libs ?

@michalsnik michalsnik changed the title Fix: crash with babel-eslint [Fix] Crash with babel-eslint Dec 2, 2017
@mysticatea
Copy link
Member Author

@mysticatea
Copy link
Member Author

I upgraded eslint-plugin-vue-libs to 2.0.0.

@mysticatea
Copy link
Member Author

I'm not sure why CircleCI job is failing. This project does not depend on eslint-plugin-react, but CurcleCI said it exists.

@michalsnik Could you rebuild the job without cache? I don't have the permission.

image

@mysticatea
Copy link
Member Author

I fixed the test matter.

@michalsnik michalsnik merged commit cc43821 into master Dec 17, 2017
@michalsnik michalsnik deleted the dont-crash-with-other-parsers branch December 17, 2017 12:13
@michalsnik
Copy link
Member

Thanks @mysticatea :) And sorry for not responding earlier..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when loading 'vue/no-confusing-v-for-v-if'
2 participants