[Fix] Incorrect errors in invalid EOF cases (fixes #268) #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticatea
commented
Dec 2, 2017
| // code: '<template><div><input></input></div></template>', | ||
| // output: '<template><div><input></template>', | ||
| // errors: ["'<input>' should not have end tag."] | ||
| // }, |
There was a problem hiding this comment.
Those tests are no longer needed. It's a kind of syntax error if void elements have their extra end tag, so it's reported by vue/no-parsing-error rule.
There was a problem hiding this comment.
Okay, then please remove it :)
There was a problem hiding this comment.
It has been removed already 😀
There was a problem hiding this comment.
Apparently I need to start wearing glasses 🤓
michalsnik
changed the title
michalsnik
approved these changes
Dec 2, 2017
| // code: '<template><div><input></input></div></template>', | ||
| // output: '<template><div><input></template>', | ||
| // errors: ["'<input>' should not have end tag."] | ||
| // }, |
There was a problem hiding this comment.
Okay, then please remove it :)
|
Please remove those commented lines and we're good to merge it. Good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #268 and some similar cases:
I.e. some rules are confused in invalid EOF. This PR fixes some rules to not report errors if the code has invalid EOF.