Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: upgrade vue-eslint-parser #34

Merged
merged 2 commits into from
Jun 18, 2017
Merged

Fix: upgrade vue-eslint-parser #34

merged 2 commits into from
Jun 18, 2017

Conversation

mysticatea
Copy link
Member

This upgrading will solve 2 problems.

  1. Ensure making correct ASTs about self-closing elements (fixes Self closing elements break v-if rules #29). The first impression was difficult, but actually this was easy. (diff: vuejs/vue-eslint-parser@b954bee)
  2. Improve the integration with eslint-plugin-import (refs Compatibility with ESLint 4 #21 (comment)). I avoid that error as I use parser.parseForESLint() alias. (diff: vuejs/vue-eslint-parser@62acbe8)

Additionally, I added some tests about above.

- Make correct ASTs about self-closing elements (fixes #29)
- Improve the integration with eslint-plugin-import (refs #21)
@michalsnik
Copy link
Member

Good work @mysticatea. I didn't know about parseForESLint, seems like a decent solution. Btw. pretty clever way of testing this integration, not so obvious at first sight but does the job 👍

@mysticatea mysticatea merged commit 22aeca5 into master Jun 18, 2017
@mysticatea mysticatea deleted the fix-self-closing branch June 18, 2017 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self closing elements break v-if rules
2 participants