Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing F2 on SFC template tag isn't restricted to tag pair #1201

Closed
h-h-h-h opened this issue Apr 15, 2022 · 0 comments
Closed

Pressing F2 on SFC template tag isn't restricted to tag pair #1201

h-h-h-h opened this issue Apr 15, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@h-h-h-h
Copy link

h-h-h-h commented Apr 15, 2022

For HTML files, VS Code just changes the pair of matching opening and closing tag when renaming in with F2.

But in templates of Vue SFCs, this:

<template>
  <div></div>
  <di|v></div>  <!-- cursor here -->
  <div></div>
</template>

...becomes this:

<template>
  <span></span>
  <span|></span>
  <span></span>
</template>

...although it should become this:

<template>
  <div></div>
  <span|></span>
  <div></div>
</template>
@johnsoncodehk johnsoncodehk added the bug Something isn't working label Apr 15, 2022
johnsoncodehk added a commit that referenced this issue Apr 15, 2022
@johnsoncodehk
fix: use html renaming instead of ts renaming on tags
fe4cef4 
close #1201
johnsoncodehk added a commit that referenced this issue Apr 15, 2022
@johnsoncodehk
Squashed commit of the following:
e8feb2e 
commit fe4cef4
Author: johnsoncodehk <johnsoncodehk@gmail.com>
Date:   Fri Apr 15 22:07:42 2022 +0800

    fix: use html renaming instead of ts renaming on tags

    close #1201

commit 83b922f
Author: johnsoncodehk <johnsoncodehk@gmail.com>
Date:   Fri Apr 15 21:33:49 2022 +0800

    feat: add option `experimentalShamefullySupportOptionsApi`
johnsoncodehk added a commit that referenced this issue Apr 15, 2022
@johnsoncodehk
fix: use html renaming instead of ts renaming on tags
0a3d7b6 
close #1201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@h-h-h-h @johnsoncodehk