New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat-req] vue-tsc support for symlinked files whose entities are outside the rootDir. #738
Labels
bug
Something isn't working
Comments
Thanks for the report! I need to survey how tsc handle this. |
vikunja-bot
pushed a commit
to go-vikunja/frontend
that referenced
this issue
Nov 28, 2021
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [vue-tsc](https://github.com/johnsoncodehk/volar) | devDependencies | patch | [`0.29.6` -> `0.29.7`](https://renovatebot.com/diffs/npm/vue-tsc/0.29.6/0.29.7) | --- ### Release Notes <details> <summary>johnsoncodehk/volar</summary> ### [`v0.29.7`](https://github.com/johnsoncodehk/volar/blob/master/CHANGELOG.md#​0297) [Compare Source](vuejs/language-tools@v0.29.6...v0.29.7) - feat: support html, css custom data ([#​707](vuejs/language-tools#707)) - feat: support extends tsconfig `vueCompilerOptions` ([#​731](vuejs/language-tools#731)) - fix: cannot config project reference by directory path ([#​712](vuejs/language-tools#712)) - fix: pug attrs type-check borken by nested tags ([#​721](vuejs/language-tools#721)) - fix: import path rename result incorrect ([#​723](vuejs/language-tools#723)) - fix: `editor.codeActionsOnSave: ["source.organizeImports"]` not working ([#​726](vuejs/language-tools#726)) - fix: goto definition not working with some component import statement ([#​728](vuejs/language-tools#728)) - fix: don't show volar commands in non-vue document ([#​733](vuejs/language-tools#733)) - fix: vue-tsc not working with symlink ([#​738](vuejs/language-tools#738)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Reviewed-on: https://kolaente.dev/vikunja/frontend/pulls/1106 Reviewed-by: dpschen <dpschen@noreply.kolaente.de> Co-authored-by: renovate <renovatebot@kolaente.de> Co-committed-by: renovate <renovatebot@kolaente.de>
Thank you for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Can vue-tsc support the import of symlinks that have entities outside the rootDir?
https://github.com/sinbino/issue-vue-tsc-symlink
Above is a reproduction repository of the problem.
In main-proj, there is a "types" directory that is a symlink to sub-proj.
The index.ts in main-proj imports the hello.ts in "types" directory.
This project compiles successfully in tsc, but fails in vue-tsc with the following error.
"error TS6059: File 'sub-proj/src/types/hello.ts' is not under 'rootDir' 'main-proj'. 'rootDir' is expected to contain all source files."
The text was updated successfully, but these errors were encountered: