Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite vscode-vue-languageservice #1009

Merged
merged 55 commits into from Mar 9, 2022
Merged

Rewrite vscode-vue-languageservice #1009

merged 55 commits into from Mar 9, 2022

Conversation

johnsoncodehk
Copy link
Member

Close #763

@johnsoncodehk johnsoncodehk marked this pull request as draft March 5, 2022 13:27
@johnsoncodehk
refactor: rewrite formatting to use plugins
68cc581
@johnsoncodehk
refactor: move formatter to language service plugins
dfa9ba3
@johnsoncodehk
refactor: implement auto insertion features by plugins
f5e64cc
@johnsoncodehk
fix: don't allow additional completion with different document
e4252a0
@johnsoncodehk
refactor: implement component props, auto-import completion in plugin
e1ace69
@johnsoncodehk
refactor: reduce create ts plugins code
5533518
@johnsoncodehk
chore: fix test
0c1e82e
@johnsoncodehk
refactor: move completed features to documentFeatures, languageFuatur…
c3b4e15 
…es dirs
@johnsoncodehk
refactor: simplify embedded language source maps usage
3b7d846
@johnsoncodehk
refactor: rewrite documentHighlights, documentLinks to use plugin
b383e0b
@johnsoncodehk
refactor: rewrite callHierarchy to use plugin
ccc69e0
@johnsoncodehk
fix: do combine even with one result to dedupe
ce3665f
@johnsoncodehk
chore: rename SourceFile -> VueDocument
42501cd
@johnsoncodehk
fix: make additional completion lower priority
c0f44b7
@johnsoncodehk
Copy link
Member Author

johnsoncodehk commented Mar 7, 2022 •
edited

@yaegassy no problem, let me know anytime if you found any problems.

Thank you to quick adjustment the language client!

@yaegassy
Copy link
Collaborator

yaegassy commented Mar 8, 2022

@johnsoncodehk There seems to be a typo. difinition -> definition. 2cac63e

@johnsoncodehk johnsoncodehk mentioned this pull request Mar 8, 2022
Closed
@johnsoncodehk johnsoncodehk marked this pull request as ready for review March 9, 2022 12:19
@johnsoncodehk johnsoncodehk merged commit 271cdc7 into master Mar 9, 2022
@johnsoncodehk
Copy link
Member Author

NOTE: The refactoring is not done, this is just a paragraph

@johnsoncodehk johnsoncodehk deleted the rewrite-language-features branch March 9, 2022 14:44
@johnsoncodehk johnsoncodehk mentioned this pull request Mar 14, 2022
Closed
@johnsoncodehk johnsoncodehk mentioned this pull request Apr 26, 2022
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite vscode-vue-languageservice
2 participants
@johnsoncodehk @yaegassy