Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow data with the same name as components #3744

Closed
wants to merge 3 commits into from
Closed

fix: allow data with the same name as components #3744

wants to merge 3 commits into from

Conversation

so1ve
Copy link
Member

@so1ve so1ve commented Nov 21, 2023

fixes #3411

@johnsoncodehk
Copy link
Member

This seems to break component type narrowing and fail the #3138 test of the latest commit: dc2432f

@so1ve
Copy link
Member Author

so1ve commented Nov 29, 2023

🤔 I'll take a look

@so1ve
Copy link
Member Author

so1ve commented Dec 6, 2023

Failing with another error :(

@johnsoncodehk
Copy link
Member

After thinking about it, I think this operation should not be done in Vue language tools, let's wait: vuejs/core#3399

Thank you for your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component names may not match other component properties
2 participants
@so1ve @johnsoncodehk