perf(tsc): support vue files with project reference delcaration #3751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blake-newman
force-pushed
the
blake.newman/vue-project-referenc-perf
branch
from
25c7a84
to
f835ad7
Compare
|
Solves #3526 |
|
Note there is a similar patch here inside volar: As volar is meant to be framework agnostic it probably needs to be applied at vue-tsc layer, but i'm now investigating if this impacts vscode and should be resolved in volar. |
blake-newman
force-pushed
the
blake.newman/vue-project-referenc-perf
branch
from
f835ad7
to
4027ee7
Compare
Support vue files with project reference output, so that typescript resolves the project reference vue file as the output `vue.d.ts` file rather than the source. This drastically improves performance in large projects that have vue files imported from project references. As much as 50% performance improvements as ts no longer recompiles vue files from source. Setup the real path to pass back the real path of vue files, as they are virtual files the inbuilt realpath always returns the non symlinked version (node_modules), which affects DX with vue-tsc as errors originating from upstream project reference packages are returned with the node modules path rather than the source. This change is also required to power the usage of `d.ts` files.
blake-newman
force-pushed
the
blake.newman/vue-project-referenc-perf
branch
from
4027ee7
to
25b50fc
Compare
41 tasks
johnsoncodehk
force-pushed
the
master
branch
4 times, most recently
from
1366ddb
to
7e1a61c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support vue files with project reference output, so that typescript resolves the project reference vue file as the output
vue.d.tsfile rather than the source.This drastically improves performance in large projects that have vue files imported from project references. As much as 50% performance improvements as ts no longer recompiles vue files from source.
Setup the real path to pass back the real path of vue files, as they are virtual files the inbuilt realpath always returns the non symlinked version (node_modules), which affects DX with vue-tsc as errors originating from upstream project reference packages are returned with the node modules path rather than the source. This change is also required to power the usage of
d.tsfiles.