Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(language-service): drag and drop import respects tsconfig path aliases #4184

Merged
merged 5 commits into from Mar 31, 2024

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Mar 31, 2024

Closes #4125

TODO:

  • Respect typescript.preferences.importModuleSpecifier setting

@johnsoncodehk johnsoncodehk changed the title feat: drag and drop Import respects tsconfig path aliases feat: drag and drop import respects tsconfig path aliases Mar 31, 2024
fromCacheOnly?: boolean
): { exportInfo?: SymbolExportInfo, moduleSpecifier: string, computedWithoutCacheCount: number; } | undefined;
};
} = (ts as any).codefix;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it work? 🧐
Will typescript secretly export some internal services?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, some APIs are not exposed in dts.

@johnsoncodehk johnsoncodehk marked this pull request as ready for review March 31, 2024 19:27
@johnsoncodehk johnsoncodehk changed the title feat: drag and drop import respects tsconfig path aliases feat(language-service): drag and drop import respects tsconfig path aliases Mar 31, 2024
@johnsoncodehk johnsoncodehk merged commit 4f162a1 into master Mar 31, 2024
6 checks passed
@johnsoncodehk johnsoncodehk deleted the tsconfig-for-drag-and-drop branch March 31, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Drag and Drop Component Import respects tsconfig path aliases
2 participants