Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(language-core): improve maintainability of codegen #4276

Merged
merged 11 commits into from
Apr 21, 2024
Merged

refactor(language-core): improve maintainability of codegen #4276

merged 11 commits into from
Apr 21, 2024
+3,929 −3,662

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Apr 16, 2024 •
edited
Loading

  • No longer supports codegen stack to simplify the code.
  • Deprecated vueCompilerOptions.nativeTags, now respects the nodeType property of template AST node.
  • Dynamic component types without v-bind:is are no longer supported. 
    ✅ This ok
<component :is="Foo" />

❌ No longer support
<component is="Foo" />
<component is="a" />
  • CodeGen has been reorganized into multiple files.
  • Improved partial code reusability.

@johnsoncodehk johnsoncodehk marked this pull request as ready for review April 21, 2024 08:46
@johnsoncodehk johnsoncodehk merged commit f46634c into master Apr 21, 2024
6 checks passed
@johnsoncodehk johnsoncodehk deleted the new-codegen branch April 21, 2024 08:53
@zam157 zam157 mentioned this pull request Apr 27, 2024
Closed
@snyk-io snyk-io bot mentioned this pull request May 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@johnsoncodehk