Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(language-core): move declare defineProp out of function scope #4454

Merged
merged 4 commits into from
Jun 21, 2024
Merged

fix(language-core): move declare defineProp out of function scope #4454

merged 4 commits into from
Jun 21, 2024

Conversation

zhiyuanzmj
Copy link
Contributor

@zhiyuanzmj zhiyuanzmj commented Jun 9, 2024 •
edited
Loading

1. Add PropOptions type for defineProp

image

2. prevent declare function in function scope.

image

@johnsoncodehk
Copy link
Member

LGTM, thanks!

@johnsoncodehk johnsoncodehk merged commit 0781998 into vuejs:master Jun 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@so1ve so1ve so1ve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhiyuanzmj @johnsoncodehk @so1ve