fix(types): typescript 5.0 acceptHMRUpdate error (#2098) (#2152)

Co-authored-by: kalvens <kalvens@rtvision.com>

package.json

@@ -50,7 +50,7 @@
     "semver": "^7.5.0",
     "typedoc": "^0.23.28",
     "typedoc-plugin-markdown": "^3.14.0",
-    "typescript": "^4.9.4",
+    "typescript": "^5.0.4",
     "vitest": "^0.30.1",
     "vue": "^3.2.47",
     "yorkie": "^2.0.0"

packages/nuxt/package.json

@@ -54,7 +54,7 @@
     "@nuxt/schema": "^3.0.0",
     "@nuxt/test-utils": "^3.0.0",
     "nuxt": "^3.0.0",
-    "typescript": "^4.8.4",
+    "typescript": "^5.0.4",
     "vue-tsc": "^1.2.0"
   },
   "publishConfig": {

packages/pinia/src/hmr.ts

@@ -1,6 +1,14 @@
 import { isRef, isReactive, isVue2, set } from 'vue-demi'
 import { Pinia } from './rootStore'
-import { isPlainObject, StoreDefinition, StoreGeneric, _Method } from './types'
+import {
+  isPlainObject,
+  StateTree,
+  StoreDefinition,
+  StoreGeneric,
+  _GettersTree,
+  _Method,
+  _ActionsTree,
+} from './types'
 
 /**
  * Checks if a function is a `StoreDefinition`.
@@ -70,7 +78,12 @@ export function patchObject(
  * @param initialUseStore - return of the defineStore to hot update
  * @param hot - `import.meta.hot`
  */
-export function acceptHMRUpdate(initialUseStore: StoreDefinition, hot: any) {
+export function acceptHMRUpdate<
+  Id extends string = string,
+  S extends StateTree = StateTree,
+  G extends _GettersTree<S> = _GettersTree<S>,
+  A = _ActionsTree
+>(initialUseStore: StoreDefinition<Id, S, G, A>, hot: any) {
   // strip as much as possible from iife.prod
   if (!__DEV__) {
     return () => {}

packages/pinia/test-dts/store.test-d.ts

@@ -1,4 +1,4 @@
-import { StoreGeneric, defineStore, expectType } from './'
+import { StoreGeneric, acceptHMRUpdate, defineStore, expectType } from './'
 import { UnwrapRef, watch } from 'vue'
 
 const useStore = defineStore({
@@ -142,6 +142,10 @@ defineStore({
 
 const store = useStore()
 
+if (import.meta.hot) {
+  import.meta.hot.accept(acceptHMRUpdate(useStore, import.meta.hot))
+}
+
 expectType<{ a: 'on' | 'off' }>(store.$state)
 expectType<number>(store.nested.counter)
 expectType<'on' | 'off'>(store.a)

packages/playground/src/stores/counter.ts

@@ -2,9 +2,7 @@ import { acceptHMRUpdate, defineStore } from 'pinia'
 
 const delay = (t: number) => new Promise((r) => setTimeout(r, t))
 
-export const useCounter = defineStore({
-  id: 'counter',
-
+export const useCounter = defineStore('counter', {
   state: () => ({
     n: 2,
     incrementedTimes: 0,