fix: use assign to set $state

Fix #682
vuejs · Sep 29, 2021 · f3a732f · f3a732f
1 parent a741adc
commit f3a732f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/pinia/__tests__/store.spec.ts b/packages/pinia/__tests__/store.spec.ts
@@ -137,6 +137,11 @@ describe('Store', () => {
 
   it('can replace its state', () => {
     const store = useStore()
+    const spy = jest.fn()
+    watch(() => store.a, spy, { flush: 'sync' })
+    expect(store.a).toBe(true)
+
+    expect(spy).toHaveBeenCalledTimes(0)
     // TODO: remove once plugin state achieve generics
     // @ts-expect-error
     store.$state = {
@@ -148,6 +153,8 @@ describe('Store', () => {
         },
       },
     }
+    expect(spy).toHaveBeenCalledTimes(1)
+
     expect(store.$state).toEqual({
       a: false,
       nested: {

diff --git a/packages/pinia/src/store.ts b/packages/pinia/src/store.ts
@@ -532,7 +532,9 @@ function createSetupStore<
       if (__DEV__ && hot) {
         throw new Error('cannot set hotState')
       }
-      pinia.state.value[$id] = state
+      $patch(($state) => {
+        assign($state, state)
+      })
     },
   })