Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change acceptHMRUpdate weird code (if (!(process.env.NODE_ENV !== 'production'))) #2162

Closed
0x00A1FA opened this issue Apr 21, 2023 · 1 comment

Comments

@0x00A1FA
Copy link

What problem is this solving

Helping developers understand the code better.

Proposed solution

Use if (if (process.env.NODE_ENV === 'production')) instead.

Describe alternatives you've considered

Off-topic: By the way, your issue form retained one element from what I presume is the old issue template from the Vue Router: Before creating a feature request make sure that: This hasn't been [requested before](https://github.com/vuejs/router/issues). (check out the requested before link).

posva added a commit that referenced this issue Apr 21, 2023
Copy link
Member

posva commented Apr 21, 2023

Thanks, I fixed the link! The code you are looking at is generated. The source code is just if (!__DEV__)

@posva posva closed this as not planned Won't fix, can't repro, duplicate, stale Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants