Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added translation of documentation into Russian #2045

Closed
wants to merge 8 commits into from

Conversation

Ibochkarev
Copy link

Starting translation into Russian and configuring the locale

@netlify
Copy link

netlify bot commented Mar 2, 2023

Deploy Preview for pinia-official ready!

Name Link
🔨 Latest commit 87bccfb
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/6402eca68e628500089d04a1
😎 Deploy Preview https://deploy-preview-2045--pinia-official.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Ibochkarev Ibochkarev marked this pull request as ready for review March 4, 2023 06:48
@Ibochkarev Ibochkarev changed the title docs(ru): Starting translation into Russian Added translation of documentation into Russian Mar 4, 2023
@Ibochkarev
Copy link
Author

@posva Good day! Are there any difficulties in the approval of this PR?

@Ibochkarev
Copy link
Author

Up!

@posva
Copy link
Member

posva commented Apr 10, 2023

Thanks for the PR but please don't "Up!" the PR because it creates notifications for the maintainers. This is already in my Todo list, we are adding some translation contribution guidelines to the router and pinia to make the process more clear. I will come back to you as soon as I can. Thanks!

@posva posva added the 📚 docs Related to documentation changes label Apr 12, 2023
@Ibochkarev
Copy link
Author

@posva Good afternoon!
Is there any chance that this PR will be accepted?

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this hosted outside of this repo? Similar to the other translations. It should also be the work of multiple people (like the other translations) to ensure it's kept up to date. I think https://github.com/translation-gang was doing Russian Translations

@Leronez
Copy link
Contributor

Leronez commented Oct 6, 2023

This pr is no longer needed, as a link to the Russian documentation has been added in another pr, #2438 . I contacted @Ibochkarev , and he agreed to contribute his translations to the current translation repository for Pinia (https://github.com/translation-ru/pinia/).

@posva
Copy link
Member

posva commented Oct 6, 2023

Thanks!

@posva posva closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Related to documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants