Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce the unnecessary use of markRaw #2204

Merged
merged 1 commit into from
May 16, 2023

Conversation

Mini-ghost
Copy link
Contributor

Is it necessary to use markRaw for actionSubscriptions and subscriptions here?

let subscriptions: SubscriptionCallback<S>[] = markRaw([])
let actionSubscriptions: StoreOnActionListener<Id, S, G, A>[] = markRaw([])

I have examined the context of the source code, and it appears that actionSubscriptions and subscriptions are never potentially converted to proxy at any point in the code. Additionally, users do not have access to these arrays. Given this information, is it still necessary to use markRaw for them?

@netlify
Copy link

netlify bot commented May 16, 2023

Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit b5f1264
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/6463a422664cac00080e6805

@codecov-commenter
Copy link

Codecov Report

Merging #2204 (b5f1264) into v2 (d710cb8) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##               v2    #2204   +/-   ##
=======================================
  Coverage   94.07%   94.07%           
=======================================
  Files          14       14           
  Lines        3378     3378           
  Branches      230      230           
=======================================
  Hits         3178     3178           
  Misses        196      196           
  Partials        4        4           
Impacted Files Coverage Δ
packages/pinia/src/store.ts 84.07% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@posva posva merged commit b041c15 into vuejs:v2 May 16, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants