refactor: reduce the unnecessary use of markRaw
#2204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it necessary to use
markRaw
foractionSubscriptions
andsubscriptions
here?pinia/packages/pinia/src/store.ts
Lines 258 to 259 in d710cb8
I have examined the context of the source code, and it appears that
actionSubscriptions
andsubscriptions
are never potentially converted to proxy at any point in the code. Additionally, users do not have access to these arrays. Given this information, is it still necessary to usemarkRaw
for them?