-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): remove invalid character from id. #2292
Conversation
✅ Deploy Preview for pinia-official ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks but this are generated. They should be changed in the generation script in the docs package folde
@posva ohh, should have taken more time to see it carefully. Can I still make the changes or is better to open an issue? |
Make the changes but don’t open an issue about this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant the changes to the script that generates the docs 😅
Doesn't |
Oh sorry, I didn't see on the phone. I'm starting to think this should actually be handled by vitepress 🤔 It should probably use |
@posva I'm not that good to understand your solution, but I think So using |
oa |
When I try to click on any element with the dolar sign I get the following error:
This is happening because the
id
attribute has an invalid character ($
).https://pinia.vuejs.org/api/interfaces/pinia._StoreWithState.html