fix(devtools): Do not patch mocked actions #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pinia-official canceled.
|
bodograumann
force-pushed
the
fix-devtools-testing-compat
branch
from
07524a5
to
335aa23
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## v2 #2300 +/- ##
=======================================
Coverage 93.80% 93.80%
=======================================
Files 11 11
Lines 2858 2858
Branches 182 182
=======================================
Hits 2681 2681
Misses 175 175
Partials 2 2 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Any ETA on this getting merged? |
|
Anything I can do to get this merged, @posva ? |
|
This looks great, thanks for the PR! I haven’t been able to give this a look, sorry. |
posva
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were no devtools unittests afaics, so I added a new file.
Usually devtools are not loaded during unit tests, so I had to do the testing on the inner-most exposed level.
I am simulating a testing pinia with mocked actions and check that they are "sufficiently" preserved.
Fixes #2298