Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #2634

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Update index.md #2634

merged 1 commit into from
Apr 3, 2024

Conversation

HP8585
Copy link
Contributor

@HP8585 HP8585 commented Apr 3, 2024

in line 71 there were 2 mistakes , the first one is "Note you must" is absolutely wrong, it must be "Note that you must...", the second mistake is you called Pinia "pinia" in a non-code area which is wrong again...

in line 71 there were 2 mistakes , the first one is "Note you must" is absolutely wrong, it must be "Note that you must...", the second mistake is you called Pinia "pinia" in a non-code area which is wrong again...
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for pinia-playground canceled.

Name Link
🔨 Latest commit e4ff245
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/660d4b8014fc3700080e928f

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for pinia-official ready!

Name Link
🔨 Latest commit e4ff245
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/660d4b8016f7110008115a45
😎 Deploy Preview https://deploy-preview-2634--pinia-official.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! FYI both can be used.
As a friendly recommendation for future contributions: you might want to communicate in more friendly/willing-to-help way rather than sounding criticizing ("is absolutely wrong", "you called [...] which is wrong again...") 😉

@posva posva merged commit 98493b5 into vuejs:v2 Apr 3, 2024
4 checks passed
niceplugin added a commit to niceplugin/Vuejs-Pinia-KO that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants