Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update this fork of the plugin - Resolved conflicts #12

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open

Update this fork of the plugin - Resolved conflicts #12

wants to merge 63 commits into from

Conversation

jagoncalves14
Copy link

The work on this PR has been paused for more than a year now.
Recently, I worked on a project where the whitelisting ability — which is present on the GoogleChromeLabs/preload-webpack-plugin — would be really handy.

For what I saw, the only thing that was stopping the merge on the other PR was merge conflicts. Since I wasn't able to solve them directly for @jeffposnick, I did a new fork and solved them myself.

Let me know your thoughts on this. 👌

laysent and others added 30 commits September 3, 2017 19:08
Add excludeHtmlNames to solve problem mentioned in GoogleChromeLabs#48
…ML - it should not be attempted to filtered as if it were a chunk, they are just files to be black/whitelisted in config
Fixed all-assets being treated as a real chunk in doesChunkBelongToHML
+ use pascal case: "all-assets" to "allAssets"
+ rename "all" to "allChunks"
Provide a way to include all assets (issue #35)
@jeffposnick
Copy link

@housseindjirdeh is the current "owner of record" for preload-webpack-plugin.

One of the open questions was whether he would maintain it going forward or whether finding a new home with a different maintainer made the most sense. I see that this repo is in the vuejs org—is Vue interested in maintaining the plugin?

I'll let you and Houssein discuss 😄

@jagoncalves14
Copy link
Author

@housseindjirdeh is the current "owner of record" for preload-webpack-plugin.

One of the open questions was whether he would maintain it going forward or whether finding a new home with a different maintainer made the most sense. I see that this repo is in the vuejs org—is Vue interested in maintaining the plugin?

I'll let you and Houssein discuss 😄

I thought this repo was from @sodatea, since he is the author from the last 2 releases 😄
Anyway, I'm hoping someone replies to this to see if we can do a little revival to the repo 🤘

Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help. But the tests are not runnable, so there's still much work to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants