lower html-webpack-plugin 4 peer dependency version 4.5.1 -> 4.5.0 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also I am not sure if I should lower dependency version for webpack4 e2e tests as well. Changing it from ^4.5.1 to ^4.5.0 wouldn't really affect anything, because version 4.5.2 is installed regardless, but it would be consistent with peer dependency version. |
Twipped
added a commit
to Twipped/preload-webpack-plugin
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Npm 7+ doesn't allow installing preload-webpack-plugin alongside html-webpack-plugin 4.5.0 without runnig --legacy-peer-deps, although it works fine with 4.5.0 version.
I use Create React App v.4.0.3 and have no control over html-webpack-plugin version, but i wanted to customize CRA config without ejecting and i believe many people would potentially want to do the same.