Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Typescript support #109

Merged
merged 6 commits into from
Jul 18, 2017
Merged

Typescript support #109

merged 6 commits into from
Jul 18, 2017

Conversation

Jack-Works
Copy link

@Jack-Works Jack-Works commented Jul 2, 2017

Fixes #99 .

Now we can use

<script lang="ts">
    interface ITypescriptCodeHere {}
</script>

And add support to inject code like this

import App from './app.ts'
export default App

this will generate

var __$App= Object.assign(App, {
    /*  renders, _scopeIDs and other stuff will injected to here */
})
__$App.prototype = App.prototype
export default __$App

/ping @znck

@Jack-Works
Copy link
Author

Jack-Works commented Jul 2, 2017

Hmm, I fix the eslint problem, but I get stuck in the unit test.
They are 1) should rollup coffee.vue
See details in CI result.
I have no idea about what is messed up.

Any help? Thanks. @znck

@znck
Copy link
Member

znck commented Jul 2, 2017

Thanks a lot @Jack-Works.

I would review it later this week.

@znck znck self-requested a review July 3, 2017 07:36
@Jack-Works
Copy link
Author

@znck Em.. Hello?

@znck
Copy link
Member

znck commented Jul 15, 2017

Sorry! I was caught up with some things. I'd try to this week.

@znck
Copy link
Member

znck commented Jul 18, 2017

Hey @Jack-Works

Apologies for the delay. Tests all green now. Please add covering tests for your change.

Thanks.

@znck znck added this to the Version 2.4 milestone Jul 18, 2017
@Jack-Works
Copy link
Author

@znck All tests passed I think...

@znck znck merged commit 240c0f7 into vuejs:master Jul 18, 2017
@Jack-Works Jack-Works deleted the typescript-support branch July 20, 2017 08:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants