Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Preserve case in templates #82

Merged
merged 3 commits into from
May 9, 2017
Merged

Conversation

posva
Copy link
Member

@posva posva commented Mar 28, 2017

Currently the compiled result of a template yields a lowercase version
while it should keep the original case.

Helps #81 .

/ping @znck

@posva
Copy link
Member Author

posva commented Mar 28, 2017

BTW, I tested on vue repo in case the error was coming from there, but it wasn't. Also updating the packages didn't fix it

@znck znck added the bug label May 3, 2017
@znck znck requested review from znck and removed request for znck May 3, 2017 07:16
@znck znck self-assigned this May 3, 2017
posva and others added 3 commits May 8, 2017 20:00
Currently the compiled result of a template yields a lowercase version
while it should keep the original case.
Just to trigger CI build.
@posva
Copy link
Member Author

posva commented May 8, 2017

ping @znck I got this fixed!

@posva
Copy link
Member Author

posva commented May 8, 2017

By the way, why do you have * as the version of vue-template-compiler?

@znck
Copy link
Member

znck commented May 9, 2017

vue & vue-template-compiler must have same version.

To make it work with any version, both vue and vue-template-compiler are set to *.

Is it bad?

@posva
Copy link
Member Author

posva commented May 9, 2017

I don't know if it's bad, I was just wondering why 🙂

@posva posva changed the title Add failing test for uppercase copmonent Preserve case in templates May 9, 2017
@znck znck merged commit 713c5a6 into vuejs:master May 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants