fix(encoding): keep decoded hash when resolving

vuejs · Oct 2, 2020 · 1a8ffc1 · 1a8ffc1
1 parent 367f063
commit 1a8ffc1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/__tests__/urlEncoding.spec.ts b/__tests__/urlEncoding.spec.ts
@@ -128,4 +128,17 @@ describe('URL Encoding', () => {
       query: { p: '%' },
     })
   })
+
+  it('keeps decoded values in hash', async () => {
+    // @ts-ignore: override to make the difference
+    encoding.decode = () => 'd'
+    // @ts-ignore
+    encoding.encodeHash = () => '#e'
+    const router = createRouter()
+    await router.push({ name: 'home', hash: '#%' })
+    expect(router.currentRoute.value).toMatchObject({
+      fullPath: '/#e',
+      hash: '#%',
+    })
+  })
 })
diff --git a/src/router.ts b/src/router.ts
@@ -455,7 +455,7 @@ export function createRouter(options: RouterOptions): Router {
     }
 
     let matchedRoute = matcher.resolve(matcherLocation, currentLocation)
-    const hash = encodeHash(rawLocation.hash || '')
+    const hash = rawLocation.hash || ''
 
     if (__DEV__ && hash && !hash.startsWith('#')) {
       warn(
@@ -470,7 +470,7 @@ export function createRouter(options: RouterOptions): Router {
     const fullPath = stringifyURL(
       stringifyQuery,
       assign({}, rawLocation, {
-        hash,
+        hash: encodeHash(hash),
         path: matchedRoute.path,
       })
     )