fix(router-view): disable inheritAttrs

Fix #674
vuejs · Dec 24, 2020 · 1e58574 · 1e58574
1 parent 034c71c
commit 1e58574
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/__tests__/RouterView.spec.ts b/__tests__/RouterView.spec.ts
@@ -293,6 +293,15 @@ describe('RouterView', () => {
     expect(wrapper.html()).toBe(`<div>id:foo;other:fixed</div>`)
   })
 
+  it('inherit attributes', async () => {
+    const { wrapper } = await factory(routes.withIdAndOther, {
+      'data-test': 'true',
+    })
+    expect(wrapper.html()).toBe(
+      `<div data-test="true">id:foo;other:fixed</div>`
+    )
+  })
+
   it('can pass a function as props', async () => {
     const { wrapper } = await factory(routes.withFnProps)
     expect(wrapper.html()).toBe(`<div>id:2;other:page</div>`)

diff --git a/src/RouterView.ts b/src/RouterView.ts
@@ -36,6 +36,8 @@ export interface RouterViewProps {
 
 export const RouterViewImpl = /*#__PURE__*/ defineComponent({
   name: 'RouterView',
+  // #674 we manually inherit them
+  inheritAttrs: false,
   props: {
     name: {
       type: String as PropType<string>,