Skip to content

Commit

Permalink
Revert "test: only call browser.end on the last test"
Browse files Browse the repository at this point in the history
This reverts commit 4b3ba89.
  • Loading branch information
posva committed Apr 15, 2020
1 parent 4b3ba89 commit d3221f1
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 12 deletions.
12 changes: 0 additions & 12 deletions e2e/nightwatch.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,18 +54,6 @@ module.exports = {
},
},

// TODO: generate these and add skip tags
'chrome-headless': {
desiredCapabilities: {
browserName: 'chrome',
acceptSslCerts: true,
chromeOptions: {
w3c: false,
args: ['window-size=1280,800', 'headless'],
},
},
},

safari: {
desiredCapabilities: {
browserName: 'safari',
Expand Down
2 changes: 2 additions & 0 deletions e2e/specs/hash.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ module.exports = {
// the unencoded version, no check for the url because changes based on browser
.click('li:nth-child(5) a')
.assert.containsText('#param', 'é')

.end()
},

/** @type {import('nightwatch').NightwatchTest} */
Expand Down
8 changes: 8 additions & 0 deletions e2e/specs/modal.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ module.exports = {
.assert.urlEquals(baseURL + '/users/1')
.assert.visible('dialog')
.assert.containsText('dialog', 'User #1')

.end()
},

/** @type {import('nightwatch').NightwatchTest} */
Expand All @@ -42,6 +44,8 @@ module.exports = {
.forward()
.assert.visible('dialog')
.assert.urlEquals(baseURL + '/users/1')

.end()
},

/** @type {import('nightwatch').NightwatchTest} */
Expand All @@ -61,6 +65,8 @@ module.exports = {
.assert.urlEquals(baseURL + '/')
.assert.containsText('h1', 'Home')
.assert.not.visible('dialog')

.end()
},

/** @type {import('nightwatch').NightwatchTest} */
Expand Down Expand Up @@ -118,6 +124,8 @@ module.exports = {
.forward()
.assert.urlEquals(baseURL + '/users/1')
.assert.visible('dialog')

.end()
},

/** @type {import('nightwatch').NightwatchTest} */
Expand Down

0 comments on commit d3221f1

Please sign in to comment.