fix(scroll): avoid reusing scroll position

vuejs · May 24, 2020 · dfc1fb3 · dfc1fb3
1 parent 07100fc
commit dfc1fb3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/router.ts b/src/router.ts
@@ -652,6 +652,7 @@ export function createRouter(options: RouterOptions): Router {
     pendingLocation = toLocation
     const from = currentRoute.value
 
+    // TODO: should be moved to web history?
     if (isBrowser) {
       saveScrollPosition(
         getScrollKey(from.fullPath, info.delta),

diff --git a/src/scrollBehavior.ts b/src/scrollBehavior.ts
@@ -123,7 +123,10 @@ export function saveScrollPosition(
 }
 
 export function getSavedScrollPosition(key: string) {
-  return scrollPositions.get(key)
+  const scroll = scrollPositions.get(key)
+  // consume it so it's not used again
+  scrollPositions.delete(key)
+  return scroll
 }
 
 // TODO: RFC about how to save scroll position