Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in Edge - "0: Expected '('" #382

Closed
will-hart opened this issue Jul 23, 2020 · 2 comments · Fixed by #383
Closed

Errors in Edge - "0: Expected '('" #382

will-hart opened this issue Jul 23, 2020 · 2 comments · Fixed by #383
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@will-hart
Copy link

Version

4.0.0-beta.3

Reproduction link

https://github.com/will-hart/vuerouter4-edge-reproduction

Steps to reproduce

See the instructions in the repro readme. Basically clone, yarn, yarn serve and open in Edge.

What is expected?

Loads a minimal page

What is actually happening?

Error in the console, blank white page. The error reported is

0: Expected '('   chunk-vendors.js (1259,1)

Comment out app.use(router) in main.ts and it loads.


#317 appeared to report this issue but it was closed as a duplicate of #304. I do not believe this is a duplicate as the reported error is different and the error still occurs in beta 3.

The error might be somewhere else in the build process / configuration, but just including .use(router) causes the minimal app to break.

@posva posva added the bug Something isn't working label Jul 23, 2020
@posva
Copy link
Member

posva commented Jul 23, 2020

It's indeed missing the catch (err)! Thanks for noticing

I will get to this in a few hours so if somebody sees this isn't fixed yet, feel free to submit a PR changing the line https://github.com/vuejs/vue-router-next/blob/master/src/scrollBehavior.ts#L116 and any other line that is missing the (err)

@will-hart
Copy link
Author

Adding (err) fixes the error for me in Edge 👍

will-hart added a commit to will-hart/pixatore that referenced this issue Jul 24, 2020
Current bug in vue-router 4.0.0-beta.3
vuejs/router#382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants