Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom regex leaks to subsequent parameters without regex #679

Closed
dneuschaefer-rube opened this issue Dec 27, 2020 · 1 comment · Fixed by #680
Closed

Custom regex leaks to subsequent parameters without regex #679

dneuschaefer-rube opened this issue Dec 27, 2020 · 1 comment · Fixed by #680
Labels
bug Something isn't working

Comments

@dneuschaefer-rube
Copy link
Contributor

Version

4.0.1

Reproduction link

https://paths.esm.dev/?p=AAMeJbiAwB4U7BTA0AGBCQmoAEUduADagKA.#

Steps to reproduce

Define a path with two parameters, the first using a custom a regex and the second without.

What is expected?

The regex is applied only for the first parameter, the second parameter uses the default regex.

What is actually happening?

The custom regex is applied to both parameters.
dneuschaefer-rube added a commit to dneuschaefer-rube/vue-router-next that referenced this issue Dec 27, 2020
@dneuschaefer-rube
fix(matcher): clear customRe after consuming buffer to avoid re-use f…
69d51b0 
…or subsequent parameters

close vuejs#679
@dneuschaefer-rube dneuschaefer-rube mentioned this issue Dec 27, 2020
Merged
@posva posva added the bug Something isn't working label Dec 27, 2020
@posva
Copy link
Member

posva commented Dec 27, 2020

Thanks!

posva pushed a commit that referenced this issue Dec 27, 2020
@dneuschaefer-rube
fix(matcher): clear customRe after consuming buffer (#680)
4c0b825 
Fix #679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(matcher): clear customRe after consuming buffer dneuschaefer-rube/vue-router-next
2 participants
@posva @dneuschaefer-rube