Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe it's unnecessary to add this judgement #1691

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Conversation

MonsterPi13
Copy link
Contributor

The final element in the toSegments will always be empty or a string that is not . or ...

As a result, the toPosition will not increment when it exits the for loop and it will always be shorter than toSegments' length.

@netlify
Copy link

netlify bot commented Feb 8, 2023

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit 0128f77
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/63e36c7fdd3941000909a69f

@codecov-commenter
Copy link

Codecov Report

Merging #1691 (0128f77) into main (002f85b) will increase coverage by 0.08%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1691      +/-   ##
==========================================
+ Coverage   90.86%   90.94%   +0.08%     
==========================================
  Files          24       24              
  Lines        1116     1115       -1     
  Branches      347      346       -1     
==========================================
  Hits         1014     1014              
  Misses         63       63              
+ Partials       39       38       -1     
Impacted Files Coverage Δ
packages/router/src/location.ts 98.55% <ø> (+1.40%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are passing, so I must have forgotten to remove them. Thanks a lot for noticing!

@posva posva merged commit b298d56 into vuejs:main Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants