DOMWrapper: setValue

[lmiller1990]

combines setSelected, setChecked` etc as per #17 (comment)

[dobromir-hristov]

Should we use this issue to track the removal of set methods from Vue Wrapper and the combination of setSelected and setChecked?

[lmiller1990]

Yep, I think that makes sense.

This should be a fun ticket. We could copy paste the tests from beta (that's what I did for setChecked). Some small updates are needed (eg now we can do await setValue).

[afontcu]

I'd like to work on this! Even though I might need some guidance 😇So, in short, I should:

1. Rename current setChecked to setValue, and make sure current tests keep passing (after updating the public API, of course).

2. copy&paste setSelected tests from VTU, adapt them, and make them pass with setValue.

After that (could be another PR, and could be done after alpha-0), it should be extended to handle VueWrapper elements.

Am I in the right track?

[dobromir-hristov]

oh dang I am on it atm... Want me to push and you continue or just drop mine?

[afontcu]

oh no worries, keep on working on it :) will be busy for the next hour or so. I guess at some point we can split work and submit separate PRs 🤗

[dobromir-hristov]

Yes! I will have to go in exactly 1h :)

[lmiller1990]

The way I was expecting this to go is we keep setChecked etc, but make them private. Then setValue just checks the type of the element, and calls the correct one. But any implementation is fine. I think we should copy paste the tests for setChecked, setSelected etc where we can from beta.

[dobromir-hristov]

I was going to do that, but then I just left it as is, so you guys can comment on it.

There were quite extensive tests on those methods, not sure if I should put them in the setValue spec or not.

[lmiller1990]

Just the ones you think are relevant!

[dospunk]

This does not seem to be documented on the Migrating page https://next.vue-test-utils.vuejs.org/migration/

[lmiller1990]

This should have been backported to VTU v1 and include deprecation messages. Is that not the case?