fix: findComponent with functional components #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cexbrayat
reviewed
Nov 8, 2020
| if (node.type === selector) { | ||
| return true | ||
| } | ||
|
|
There was a problem hiding this comment.
Ain't that exactly what's done below, but maybe prevented by the condition?
I think it would be better to just extend the condition so it works with functional component (with some comments if possible)
There was a problem hiding this comment.
Good idea, I will revisit this logic. The entire function relies on a lot of side effects and mutation (mutating the vnodes array). I think we should consider rewriting it in a more immutable manner potentially 馃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#187
That was easy 馃 ... too easy ... must have broke something? Heh.