Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: emits can be an object #542

Merged
merged 1 commit into from
Apr 19, 2021
Merged

fix: emits can be an object #542

merged 1 commit into from
Apr 19, 2021
+12 −2

Commits on Apr 19, 2021

  1. fix: emits can be an object 

    The fix introduced in vuejs#521 only account for emits define as an array, but it can also be define as an object.
The latest rc.5 release breaks on components that use an object to define emits with:

    TypeError: emits.includes is not a function

This commit fixes the unit test to have both cases check, and the relevant code to properly handle the object case.
    @cexbrayat
    cexbrayat committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    0f696c5 View commit details
    Browse the repository at this point in the history