Updated description of Weex #1396

Jinjiang · 2018-01-22T08:59:38Z

Hanks10100 · 2018-01-22T10:02:58Z

src/v2/guide/comparison.md

@@ -120,7 +120,7 @@ Since you don't need to know about JSX, ES2015, or build systems to get started

 ### Native Rendering

-React Native enables you to write native-rendered apps for iOS and Android using the same React component model. This is great in that as a developer, you can apply your knowledge of a framework across multiple platforms. On this front, Vue has an official collaboration with [Weex](https://alibaba.github.io/weex/), a cross-platform UI framework developed by Alibaba Group, which uses Vue as its JavaScript framework runtime. This means with Weex, you can use the same Vue component syntax to author components that can not only be rendered in the browser, but also natively on iOS and Android!
+React Native enables you to write native-rendered apps for iOS and Android using the same React component model. This is great in that as a developer, you can apply your knowledge of a framework across multiple platforms. On this front, Vue has an official collaboration with [Weex](https://weex.apache.org/), a cross-platform UI framework driven by Alibaba Group and being incubated to Apache Software Foundation (ASF), which uses Vue as its JavaScript framework runtime. This means with Weex, you can use the same Vue component syntax to author components that can not only be rendered in the browser, but also natively on iOS and Android!


"... which uses Vue as one of its ..."

I think adding "one of" will be more accurate.

Updated. Is that OK?

chrisvfritz · 2018-01-22T17:07:20Z

@Jinjiang Thanks! From the change in wording, it sounds like Weex might now support JS frameworks other than Vue. Is that correct?

Jinjiang · 2018-01-22T23:14:04Z

Yes it already has another react-compatible framework called rax. https://github.com/alibaba/rax

chrisvfritz · 2018-01-23T01:15:48Z

@Jinjiang Thanks for clarifying. 🙂 I might want to revise that a bit, because from the wording it could be interpreted that Vue is one of the JS frameworks that the ASF uses.

Actually, I wonder if we might be complicating this section too much. What would you think if we just changed it to say Weex was created by Alibaba Group? For example:

[...] On this front, Vue has an official collaboration with Weex, a cross-platform UI framework created by Alibaba Group. Weex allows you to use the same Vue component syntax to author components that can not only be rendered in the browser, but also natively on iOS and Android!

Jinjiang · 2018-01-23T03:18:02Z

That's OK for me. 👌
And I hope @Hanks10100 could have a check too.
Thanks

Hanks10100 · 2018-01-23T03:44:14Z

Use "created" instead of "driven" looks good for me. But I think we should still mention the ASF, even if not mentioned Alibaba.

How many front-frameworks Weex support does not matter here in Vue's document. Mention it or not both fine.

Jinjiang · 2018-01-23T15:19:52Z

@chrisvfritz @Hanks10100 agree with both of you.
And because there are already some announcement about the incubation by ASF, so I preserve the ASF part description.
How about now? 🙂

Hanks10100

Everything looks good for me.

@posva

* Create new page * Update * Improve intro * Update * Add Example * Include real world example and explanation about testing * Added "Why vue" en, cn srt files into assets folder (#1367) * added english srt file * added chinese srt file * typo * fix: Correct sidebar anchor targets (#1366) Change function execution order to correct sidebar anchor targets; more concise fix to #1348. * Images not found. (#1365) Hi, The images link for `hn.png` and `hn-architecture.png` can be found on `../../images/`. * [Doc EN]: `event.md` add space to new part (#1363) * New in with + symbol Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com> * Review of 2.5.0 doc Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com> * Review Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com> * Fix syntax typo Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com> * Add space between new line of documentation Signed-off-by: MachinisteWeb <bruno.lesieur@gmail.com> * Add @posva review Signed-off-by: MachinisteWeb <bruno.lesieur@gmail.com> * Retrieve tweeningValue from onUpdate callback in documentation (#1350) The tweeningValue no longer seems to be available in the tween object itself. Instead, the tweeningValue is available in the tweened object that passed as a parameter to the onUpdate callback. * Add watch usages (#1356) * Add watch usages! Add `watch` usages! * Update index.md * tweaks to watch api examples * Avoid updating license every year (#1353) * Update spelling error and add some details about what we are testing * Update * typo for chinese subtitles of "why vue" video (#1371) * Adding Why Vue.js video to Introduction page (#1377) * Added video into guide introduction * Added modal styles to page, put video line on one file, and reset iframe margin * Fixed typo in Gulp example in deployment.md (#1376) * Update deployment.md with Grunt example (#1375) * Decoupled video player from Vimeo (#1374) * Update Installation guide to use https://caniuse.com (#1372) * [HOTFIX] initVideoModal error in common.js (#1378) * Showing all possible params of watch() (#1380) Surprised that the documentation didn't include the fact that the 2nd argument is the previous value. This can be really useful in some cases! * refactor & update sponsors display * include bronze data * fix link * fix link * add build script * update deploy docs * Small fixes (#1381) * fixed video modal bug in guide/index.md * removed unnecessary sponsors content which has been in theme layout now * fixed sponsors dropdown menu * fixed button style in team page * update Guillaume's core focus * Improve based on Sarah Drasner feedback and fix some grammar * Fixed TYPO Automatic Key Modifiers (#1388) * update community deployment instructions * Tweak wording of `.passive` modifier explanation * Add guide link in Vue.filter API (#1394) * Update filters, global filters needs to go before Vue instance creation (#1392) Global filters defined after creating the Vue instance throws `Failed to resolve filter`. Reference https://forum.vuejs.org/t/global-filters-failing-to-resolve-inside-single-file-components/21863/6 * update tree-view example to add v-for key * add details of object merging to mixins page * Revise beforeUpdate API entry, fixes vuejs/vue#7481 (#1395) * fix vue team distance sorting * Add explicit version to download links (#1398) * Add explicit version to download links * improve CDN section of installation page * demo from ’Object Change Detection‘ doesn't work (#1397) vm.$set(this.userProfile, 'age', 27) ==> vm.$set(vm.userProfile, 'age', 27); * Updated description of Weex (#1396) * updated description of Weex (close #1382) * Update comparison.md * Update "incubated to" -> "incubated by" * Update comparison.md * Update comparison.md * fix vue component require syntax for modern vue-loader * The Web Optimization Project has optimized your repository! (#1389) The Web Optimization Project optimized this repository. This commit contains the optimized files in this repository. * Fix wrapperfind(error) typo and add example to test for whitespace * Update * Use factory function to save redundant logic * Add factory function explanation and link to vue test utils guides. * Update using codebryo feedback * Change Github to GitHub (#1399) * Fixed js error when click the page (#1401) * Change cookbook entry number and reformat sentence * Change order * fix: typo in v-show description (#1408) * Create new page * Update * Improve intro * Update * Add Example * Include real world example and explanation about testing * Update spelling error and add some details about what we are testing * Update * Improve based on Sarah Drasner feedback and fix some grammar * Fix wrapperfind(error) typo and add example to test for whitespace * Update * Use factory function to save redundant logic * Add factory function explanation and link to vue test utils guides. * Update using codebryo feedback * Change cookbook entry number and reformat sentence * Change order * Rebase

updated description of Weex (close #1382)

a73ee72

Jinjiang requested a review from chrisvfritz January 22, 2018 08:59

Hanks10100 reviewed Jan 22, 2018

View reviewed changes

Jinjiang and others added 2 commits January 22, 2018 18:53

Update comparison.md

cb248a8

Update "incubated to" -> "incubated by"

6581e65

Jinjiang added 2 commits January 23, 2018 23:14

Update comparison.md

8268700

Update comparison.md

885c04a

Hanks10100 approved these changes Jan 23, 2018

View reviewed changes

chrisvfritz merged commit e390e4d into vuejs:master Jan 23, 2018

Jinjiang deleted the weex branch January 23, 2018 17:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated description of Weex #1396

Updated description of Weex #1396

Jinjiang commented Jan 22, 2018

Hanks10100 Jan 22, 2018

Jinjiang Jan 22, 2018

chrisvfritz commented Jan 22, 2018

Jinjiang commented Jan 22, 2018

chrisvfritz commented Jan 23, 2018

Jinjiang commented Jan 23, 2018

Hanks10100 commented Jan 23, 2018

Jinjiang commented Jan 23, 2018

Hanks10100 left a comment

Updated description of Weex #1396

Updated description of Weex #1396

Conversation

Jinjiang commented Jan 22, 2018

Hanks10100 Jan 22, 2018

Choose a reason for hiding this comment

Jinjiang Jan 22, 2018

Choose a reason for hiding this comment

chrisvfritz commented Jan 22, 2018

Jinjiang commented Jan 22, 2018

chrisvfritz commented Jan 23, 2018

Jinjiang commented Jan 23, 2018

Hanks10100 commented Jan 23, 2018

Jinjiang commented Jan 23, 2018

Hanks10100 left a comment

Choose a reason for hiding this comment