Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the React example less esoteric #368

Merged
merged 1 commit into from Aug 14, 2016
Merged

Make the React example less esoteric #368

merged 1 commit into from Aug 14, 2016

Conversation

insin
Copy link
Contributor

@insin insin commented Aug 14, 2016

I've never seen React code which uses curly braces the way they're used in this example.

This change doesn't put curly braces on the same line as parent elements and uses the arrow function's implicit return when mapping the list, while retaining the other decisions which have been made:

  • pointless, line-eating ( ) wrappers (which do seem to be in common use)
  • using a ternary
  • spacing of the ternary parts

@yyx990803 yyx990803 merged commit 8d0c958 into vuejs:2.0 Aug 14, 2016
Peter-WF referenced this pull request in Peter-WF/vuefe.github.io Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants