Skip to content

Commit

Permalink
Update RFC
Browse files Browse the repository at this point in the history
  • Loading branch information
yoyo930021 committed Oct 16, 2020
1 parent 6494b81 commit 6358340
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions rfcs/002-monorepo-support.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ One project scope per VLS dedicated service.
The TypeScript is support multile project in one server.
It will make one Project to one TLS.
It is based on `tsconfig.json` location.
Because only TS feature needs this feature at the moment,
Because only TypeScript/JavaScript feature needs this feature at the moment,

Example: https://github.com/angular/vscode-ng-language-service
PS. Slightly different is that the project relies entirely on TS plugins.
PS. In this example from angular, Slightly different is that the project relies entirely on TS plugins.
Similar PR: https://github.com/vuejs/vetur/pull/1734

#### Benefits
Expand All @@ -71,7 +71,7 @@ Similar PR: https://github.com/vuejs/vetur/pull/1734
- It may create something completely unnecessary TLS when having project no Vue, maybe need a lazy logic?
- In the vue ecosystem, it isn't support multiple `tsconfig.json`, It's a little redundant. [more info](https://github.com/vuejs/vetur/blob/vetur-config-file-rfc/rfcs/001-vetur-config-file.md#why-isnt-array)
- Performance is affected by the interplay between projects. unless the separation process is implemented with node `worker_threads`.
- The template interpolation need to refactor and design.
- ~~The template interpolation need to refactor and design~~, At least it's not a problem now. But I'm not sure if we'll break anything if we let Template interpolation have multiple files importing from each other.
- Because there is no defined project in VLS, register globally components could be inaccurate.


Expand Down Expand Up @@ -99,3 +99,4 @@ Not yet decided
- Have any multiple `tsconfig.json` case for a Vue project?
- What to base a project on? Use `tsconfig.json`, `package.json`, or config in [RFC](https://github.com/vuejs/vetur/pull/2378)?
- Which plan to use?
- Have any multiple `tsconfig.json` case for a other framework project? React? Angular?

0 comments on commit 6358340

Please sign in to comment.