Language Server: Problem with incorrect paths in Windows

[Narretz]

• I have searched through existing issues
• I have read through docs
• I have read FAQ

Info

• Platform: Windows
• Language Server: 0.0.56

Problem

I'm using the vls together with Language Server Protocol in Sublime Text 3.
However, the problem doesn't look like it depends on these programs.

What happens is that VLS in some cases passes the wrong path to typescript, which makes it fail when trying to find a source file. For example:

vetur/server/src/modes/script/javascript.ts

Lines 110 to 114 in 753c27b

	const fileFsPath = getFileFsPath(doc.uri);
	const rawScriptDiagnostics = [
	...service.getSyntacticDiagnostics(fileFsPath),
	...service.getSemanticDiagnostics(fileFsPath)
	];

This produces an uri like c:\Users\path\src\components\App.vue but Typescript internally has this file stored as C:/Users/path/src/components/App.vue

Reproducible Case

[octref]

in some cases passes
Do you have a specific case that I can repro?

Can you repro by modifying https://github.com/octref/veturpack?

[Narretz]

I still don't have a simple reproducible case, but I looked into this further I may have found the problem.

vls usually uses getFsFilePath to get the path to a file before it sends it to the relevant service, e.g. here:

vetur/server/src/modes/script/javascript.ts

Line 249 in 16e6f80

const fileFsPath = getFileFsPath(doc.uri);

getFsFilePath runs vscode-uri.parse().fsPath, which on Windows gives the following result with a file uri sent from Sublime LSP:
file:///C:/Users/Martin/dev/newnow/pdf_vue/src/components/HelloWorld.vue
->
c:\Users\path\src\components\App.vue

As written above, this breaks typescript in my setup (Windows + Sublime Text + Sublime LSP) because previously, the tsserver has stored the sourceFiles like so: c:/Users/path/src/components/App.vue

Now there's another function called getFilePath:

vetur/server/src/utils/paths.ts

Lines 47 to 54 in 16e6f80

	export function getFilePath(documentUri: string): string {
	const IS_WINDOWS = platform() === 'win32';
	if (IS_WINDOWS) {
	// Windows have a leading slash like /C:/Users/pine
	return Uri.parse(documentUri).path.slice(1);
	} else {
	return Uri.parse(documentUri).path;
	}

which returns exactly what we (I) need:
c:/Users/path/src/components/App.vue

Any reason why getFsFilePath instead of getFilePath is used?

I noticed that in another function, getFilePath is used to see if a file exists in the service:

vetur/server/src/modes/script/javascript.ts

Line 639 in 16e6f80

export function languageServiceIncludesFile(ls: ts.LanguageService, documentUri: string): boolean {

[mattn]

I got same. Current implementation does not handle Windows paths correctly. I'm using vim-lsp but vetur does not works eventhough another language server works fine on Windows.

[mattn]

I confirmed this issue fixes with #1662

@Narretz Could you please try this?