You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I should allow a key since with a semver value. If the aria-current-value has since: "3.2.0", then aria-current-value will only be completed if vue-router dependency in pacakge.json is >=3.2.0.
I think it makes more sense to add a tags.json file to vue-router, it should make this much easier, right? Will it still work for framework like Nuxt and Quasar that implicitly add vue-router?
We could start by copying over the existing tags to vue-router and vue-router-next repository. Will it create a conflict if both Vetur and vue-router have a tags.json file at the same time (Since some people might be using both at the same time)
Will it still work for framework like Nuxt and Quasar that implicitly add vue-router?
I can look at node_modules/vue-router for it, instead of looking at package.json.
Will it create a conflict if both Vetur and vue-router have a tags.json file at the same time
I can make the logic:
tags.json seen in vue-router: Use it
Not seen: Use Vetur's tag definition. Anyway you cannot republish old versions, so those tag data would still be useful for people who haven't upgraded.
to vue-router and vue-router-next repository
Can you create an issue telling me what to do and assign me? I'll make sure it works for Vue2/Vue3.
Today I noticed that vue-router added
aria-current-value
attribute to<router-link>
.This is added in 3.2.0: https://github.com/vuejs/vue-router/blob/dev/CHANGELOG.md#320-2020-05-19
I should allow a key
since
with a semver value. If thearia-current-value
hassince: "3.2.0"
, thenaria-current-value
will only be completed ifvue-router
dependency in pacakge.json is >=3.2.0.Another idea is to publish the
tags.json
together with: https://vuejs.github.io/vetur/framework.html. But that's one more file published withvue-router
.@posva What's your opinion?
The text was updated successfully, but these errors were encountered: