Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioned custom component support #2046

Open
octref opened this issue Jul 22, 2020 · 3 comments
Open

Versioned custom component support #2046

octref opened this issue Jul 22, 2020 · 3 comments

Comments

@octref
Copy link
Member

octref commented Jul 22, 2020

Today I noticed that vue-router added aria-current-value attribute to <router-link>.

This is added in 3.2.0: https://github.com/vuejs/vue-router/blob/dev/CHANGELOG.md#320-2020-05-19

I should allow a key since with a semver value. If the aria-current-value has since: "3.2.0", then aria-current-value will only be completed if vue-router dependency in pacakge.json is >=3.2.0.

Another idea is to publish the tags.json together with: https://vuejs.github.io/vetur/framework.html. But that's one more file published with vue-router.

@posva What's your opinion?

@posva
Copy link
Member

posva commented Jul 22, 2020

I think it makes more sense to add a tags.json file to vue-router, it should make this much easier, right? Will it still work for framework like Nuxt and Quasar that implicitly add vue-router?

We could start by copying over the existing tags to vue-router and vue-router-next repository. Will it create a conflict if both Vetur and vue-router have a tags.json file at the same time (Since some people might be using both at the same time)

@octref
Copy link
Member Author

octref commented Jul 22, 2020

Will it still work for framework like Nuxt and Quasar that implicitly add vue-router?

I can look at node_modules/vue-router for it, instead of looking at package.json.

Will it create a conflict if both Vetur and vue-router have a tags.json file at the same time

I can make the logic:

  • tags.json seen in vue-router: Use it
  • Not seen: Use Vetur's tag definition. Anyway you cannot republish old versions, so those tag data would still be useful for people who haven't upgraded.

to vue-router and vue-router-next repository

Can you create an issue telling me what to do and assign me? I'll make sure it works for Vue2/Vue3.

@posva
Copy link
Member

posva commented Jul 22, 2020

I couldn't assign you but I pinged you in both issues! Let me know on Discord if you want any help with vue-router repos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants