Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags.json and attributes.json files for Vetur #381

Closed
posva opened this issue Jul 22, 2020 · 3 comments
Closed

Add tags.json and attributes.json files for Vetur #381

posva opened this issue Jul 22, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@posva
Copy link
Member

posva commented Jul 22, 2020

See vuejs/vetur#2046

I think it makes sense to add a folder vetur and add the file paths to the package.json file like mentioned at https://vuejs.github.io/vetur/framework.html

cc @octref

@posva posva added the enhancement New feature or request label Jul 22, 2020
@posva posva closed this as completed in 1f1189f Aug 4, 2020
@posva
Copy link
Member Author

posva commented Aug 4, 2020

@octref let me know if I missed anything!

@octref
Copy link
Member

octref commented Aug 5, 2020

It's already working (duplicates because Vetur bundles vue-router tags as well).

image

I'll send another PR that updates the tags/attributes.

@posva
Copy link
Member Author

posva commented Aug 5, 2020

Ok, let me add them to current Vue Router as well and release a version in both so you can safely remove them from Vetur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants