Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTI] Configuration options #2325

Open
1 task done
andrewisaburden opened this issue Sep 25, 2020 · 4 comments
Open
1 task done

[VTI] Configuration options #2325

andrewisaburden opened this issue Sep 25, 2020 · 4 comments

Comments

@andrewisaburden
Copy link
Contributor

  • I have searched through existing issues

Feature Request

Currently VTI uses the configuration settings in initParams.ts. It would be useful to be able to configure those settings.

There seems to be a few options:

  1. Read a vscode settings.json file for the relevant vetur settings (this could be configurable by a CLI parameter, and default to the first found in the working directory)

  2. Provide CLI parameters to configure the settings

  3. Some other config file provided in the working directory.

I would like to implement one of these. 1 seems the most intuitive, except for projects that want to use VTI in their CI pipelines even though they don't typically/always use VSCode as their IDE. It seems a little odd to pollute a project with a vscode-specific settings.json, if vscode is not the mandated editor.

@yoyo930021
Copy link
Member

I think we can add vetur.config.js?

@yoyo930021
Copy link
Member

yoyo930021 commented Sep 25, 2020

Here are my personal ideas:

  1. We can use vetur.config.js for vscode some settings and VTI settings.

I can share the settings between VSCode and VTI.
I agree with reading vscode settings.json is strange.
If use vscode settings.json, I need to add this file to git, but It have some personal setting.

  1. The vetur.config.js add monorepo setting for support.

I've been thinking about monorepo support.
I'm not sure about package.json or tsconfig.json prevail in monorepo.
I think it might be better if I set it up.

@kytosai
Copy link

kytosai commented Oct 7, 2020

Here are my personal ideas:

  1. We can use vetur.config.js for vscode some settings

I can share the settings between VSCode and VTI.
I agree with reading vscode settings.json is strange.
If use vscode settings.json, I need to add this file to git, but It have some personal

Here are my personal ideas:

  1. We can use vetur.config.js for vscode some settings and VTI settings.

I can share the settings between VSCode and VTI.
I agree with reading vscode settings.json is strange.
If use vscode settings.json, I need to add this file to git, but It have some personal setting.

  1. The vetur.config.js add monorepo setting for support.

I've been thinking about monorepo support.
I'm not sure about package.json or tsconfig.json prevail in monorepo.
I think it might be better if I set it up.

I think this is a good solution for monorepo setup

Having an independent config file will help us be more proactive in setting up monorepo with different paths instead of depending on tsconfig file.

@yoyo930021
Copy link
Member

Hi everyone,

If you interested this issue,

you can go to #2377 and #2378.
View and post your ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants