Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2324 #2330

Merged
merged 3 commits into from
Oct 27, 2020
Merged

Fix #2324 #2330

merged 3 commits into from
Oct 27, 2020

Conversation

yoyo930021
Copy link
Member

@yoyo930021 yoyo930021 commented Sep 25, 2020 •
edited
Loading

Fixed #2324

andrewisaburden
andrewisaburden reviewed Sep 25, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yoyo930021
Copy link
Member Author

@andrewisaburden Thanks.
I'm sorry about I don't see I'm happy to fix these if the solutions are OK. in issue.

@andrewisaburden
Copy link
Contributor

@yoyo930021 no problem :) I hope to make some more contributions to the project as it is helpful. If it's OK with you I will implement the vetur.config.js suggestion you gave? Some time next week.

@yoyo930021
Copy link
Member Author

@yoyo930021 no problem :) I hope to make some more contributions to the project as it is helpful. If it's OK with you I will implement the vetur.config.js suggestion you gave? Some time next week.

I think we can talk over this in #2325 with @octref .

octref
octref approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@octref octref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@octref octref merged commit 63a7047 into vuejs:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewisaburden andrewisaburden andrewisaburden left review comments

@octref octref octref approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[VTI] VTI should return exit code 1 and display more useful errors on unknown errors
3 participants
@yoyo930021 @andrewisaburden @octref