Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi-root workspace #1928

Closed
wants to merge 1 commit into from
Closed

Conversation

vojvodics
Copy link

Should fix #424 and #815

Following the example at https://github.com/Microsoft/vscode-extension-samples/tree/master/lsp-multi-server-sample

It creates a new VLS for each of the workspace folders.

I'll need help to add proper test coverage and check if every command is working properly (every test passes, but it's probably not tested against multi-root workspace).

@dodas
Copy link

dodas commented May 25, 2020

Works great!

@dodas
Copy link

dodas commented Jun 4, 2020

C'mon, merge this.
This is annoying, long-lasting bug and it's finally fixed here. Bring the goodness to everyone!

@vojvodics
Copy link
Author

@dodas I don't think this is going to be merged relatively soon.

What you can do is the following:

  1. run npm i -g vsce
  2. change vscode engine version in package.json to match @types/vscode (ie "vscode": "^1.45.1")
  3. run vsce package (not sure if you need to run some scripts in package.json before this step)
  4. Open extensions sidebar, click on 3 dots, select install from VSIX and select VSIX generated file.

@dodas
Copy link

dodas commented Jun 4, 2020

I said it works great, that means I'm already using it..

Vetur is Vue's official development tool and experience using it (especially in bigger projects) is just shit. There are many bugs that have fixes waiting in PRs, yet we don't even get any feedback about when/if they are going to be merged.

@Minigugus
Copy link

#1734 ?

@vojvodics
Copy link
Author

@Minigugus I saw the PR after submitting this one. Decided not to close it, because it's using a different strategy and I was not convinced which one is better, so I'll leave it to the maintainers to decide. :)

@Minigugus
Copy link

@vojvodics

Decided not to close it, because it's using a different strategy and I was not convinced which one is better

I've noticed it too 👍 Yours seems to create one setup per root whereas mine creates one per folder (heavier but supports nested tsconfig 😜)

I'll leave it to the maintainers to decide.

The maintainers still have to answer (was initially my previous message's purpose) 😆

Perhaps we can take the best of both worlds until maintainers react 😄

@Merott
Copy link

Merott commented Jun 26, 2020

@vojvodics Could you please open the PR against this relatively popular fork of Vetur?

I could do that myself, but you did all the work! :)

Here's the link to help you open the PR in 1 click: https://github.com/hikerpig/vetur/compare/master...vojvodics:master?expand=1

@Maddimax
Copy link

Maddimax commented Aug 7, 2020

Fixed Merge conflicts here: #2129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi root support
5 participants