Semantic tokens for typescript

[jasonlyu123]

Fixed #1904
Fixed #2687
Fixed #2434
Fixed #2687

implentation

Add semantic token feature for script region. Due to typescript's implementation. It's currently not available for js. Also because of that, this is currently not available in interpolation mode. But I still left some merging strategy in the project service for potential future implementation.

A couple of things like to discuss.

1. There's some new built-in vscode command in 1.53
   Wondering if I should update the integration test to use it. The advantage is it's more integrated than a language-server request. And I don't have to copy the semantic token legend to the test script. A disadvantage is we might accidentally ship features not compatible with 1.52.

2. Computed member is highlighted as a method. Should we need to override it?

screenshot

Here is some screenshot comparison. The theme is GitHub dark.
Without semantic tokens

With semantic tokens

Without

With

[yoyo930021]

There's some new built-in vscode command in 1.53
Wondering if I should update the integration test to use it. The advantage is it's more integrated than a language-server request. And I don't have to copy the semantic token legend to the test script. A disadvantage is we might accidentally ship features not compatible with 1.52.

My understanding is that you can use them.
Testing theoretically does not affect users.

Computed member is highlighted as a method. Should we need to override it?

Do you know what it looks like in a typescript file?

[jasonlyu123]

My understanding is that you can use them.
Testing theoretically does not affect users.

Yes. It's just a very little chance that something doesn't work on an older version and we tested in a newer version so we didn't know. If you think it's ok I'll bump it.

Do you know what it looks like in a typescript file?

Should be the same as my current implementation. I haven't customized it. Because computed properties are method in the option object it has been highlighted as method not property.

[yoyo930021]

Yes. It's just a very little chance that something doesn't work on an older version and we tested in a newer version so we didn't know. If you think it's ok I'll bump it.

You can bump vscode version in the test. 👍

Should be the same as my current implementation. I haven't customized it. Because computed properties are method in the option object it has been highlighted as method not property.

If same, I think we can keep it. Get feedback after the release.
Consider doing it together with this #2434 .

[jasonlyu123]

added #2434. Currently settle with a fallback TextMate scope of entity.name.function. If anyone can think of another better highlight scope, I can change it.

You can also customize the color follow this doc after it goes live.

[yoyo930021]

I will take a look on weekend.

[yoyo930021]

LGTM
Sorry for the late reply.

[yoyo930021]

LGTM