Fix attribute description not showing if its name matches html event #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code that matches attributes from all providers on hovering attributes have found a match in the HTML tags provider (htmlTags.ts) preventing the component data description from showing up. Include '@' prefix in the collected HTML component data to not match attributes without '@'. This makes sure that hovering "@click" attribute matches the HTML provider and hovering "click" doesn't, for example. This also improves (IMO) completion labels when adding event handlers tags. Previously all labels for events from HTML provider completions would not include the `@` prefix which wasn't obvious that it's an event handler. Fixes vuejs#2900
yoyo930021
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that matches attributes from all providers on hovering
attributes have found a match in the HTML tags provider (htmlTags.ts)
preventing the component data description from showing up.
Include '@' prefix in the collected HTML component data to not match
attributes without '@'. This makes sure that hovering "@click" attribute
matches the HTML provider and hovering "click" doesn't, for example.
This also improves (IMO) completion labels when adding event handlers
tags. Previously all labels for events from HTML provider completions
would not include the
@prefix which wasn't obvious that it's anevent handler.
Fixes #2900