Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: duplicated sourceMappingURL for worker bundles (fix #11601) #11602

Merged
merged 1 commit into from
Jan 26, 2023
Merged

fix: duplicated sourceMappingURL for worker bundles (fix #11601) #11602

merged 1 commit into from
Jan 26, 2023

Conversation

Karshilov
Copy link
Contributor

@Karshilov Karshilov commented Jan 5, 2023 •
edited
Loading

Description

This PR solved this TODO, now rollup can add sourceMappingURL comment automatically , so there is no need to add it manually. Otherwise, there will be duplicated sourceMappingURL in worker bundles.

Additional context

Any comment is need?

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

patak-dev
patak-dev approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍🏼

@patak-dev patak-dev added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jan 5, 2023
@patak-dev patak-dev added this to the 4.1 milestone Jan 5, 2023
@sapphi-red sapphi-red linked an issue Jan 6, 2023 that may be closed by this pull request
Duplicated sourceMappingURL for worker bundles #11601
Closed
7 tasks
@patak-dev patak-dev merged commit 5444781 into vitejs:main Jan 26, 2023
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@Karshilov @futurGH
fix: duplicated sourceMappingURL for worker bundles (fix vitejs#11601) (
9c3e1bf 
vitejs#11602)
bluwy added a commit that referenced this pull request Jan 16, 2024
@bluwy
perf(workerImportMetaUrl): avoid parseQuery
0adb288 
we don't need the query at all since #11602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Duplicated sourceMappingURL for worker bundles
2 participants
@Karshilov @patak-dev