Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menu (navigation drawer) should not be traversable with keyboard when not shown #1332

Closed
3 tasks done
userquin opened this issue Sep 13, 2022 · 0 comments · Fixed by #1491
Closed
3 tasks done

menu (navigation drawer) should not be traversable with keyboard when not shown #1332

userquin opened this issue Sep 13, 2022 · 0 comments · Fixed by #1491
Labels
bug Something isn't working theme Related to the theme

Comments

@userquin
Copy link
Collaborator

userquin commented Sep 13, 2022

Describe the bug

When the menu is not shown (narrow screens), it shouldn't be traversable via keyboard tab.

Once the menu is shown, should have a focus trap: the tab key will traverse again the content (after a few tabs, the menu entries are traversed). The menu should trap the focus, and select the current entry once activated.

Reproduction

Open VitePress docs, resize the browser window and use the keyboard tab key.

Expected behavior

Menu shouldn't be traversable.

System Info

NA

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@userquin userquin added the bug: pending triage Maybe a bug, waiting for confirmation label Sep 13, 2022
@brc-dd brc-dd added bug Something isn't working theme Related to the theme and removed bug: pending triage Maybe a bug, waiting for confirmation labels Sep 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working theme Related to the theme
Projects
None yet
2 participants