fix(theme): Make the menu traversable only when the menu is visible #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@7nohe with tabindex we only fix focus but we need to trap focus when menu is shown. We also need to add escape key listener to hide the menu once it is shown, selecting/focusing current entry (and maybe we need to add a close button). |
|
Sure, we need to trap focus. I'll work on it later. |
Co-authored-by: Divyansh Singh <40380293+brc-dd@users.noreply.github.com>
|
accidentally pushed wrong commits. I will create new one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1332
Set
tabindex="-1"and disable tab key navigation.reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex