Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash link always added to the URL on initial page load #140

Closed
kiaking opened this issue Nov 20, 2020 · 0 comments · Fixed by #149
Closed

Hash link always added to the URL on initial page load #140

kiaking opened this issue Nov 20, 2020 · 0 comments · Fixed by #149
Assignees
@kiaking
Labels
bug Something isn't working
Projects
v1.0.0-alpha

Comments

@kiaking
Copy link
Member

kiaking commented Nov 20, 2020

When visiting a page, it will always add hash link. For example, visiting https://vitepress.vuejs.org will become https://vitepress.vuejs.org/#motivation. Hash should not be added until a visiter scrolls the page.

To Reproduce
Access https://vitepress.vuejs.org/.

Expected behavior
Hash should not be added until a visiter scrolls the page.

System Info

  • vitepress version: 0.8.0
@kiaking kiaking added the bug Something isn't working label Nov 20, 2020
@kiaking kiaking added this to To do in v1.0.0-alpha Nov 20, 2020
@kiaking kiaking self-assigned this Nov 24, 2020
@kiaking kiaking moved this from To do to In progress in v1.0.0-alpha Nov 24, 2020
@kiaking kiaking mentioned this issue Nov 24, 2020
Merged
v1.0.0-alpha automation moved this from In progress to Done Nov 24, 2020
kiaking added a commit that referenced this issue Nov 24, 2020
@kiaking
fix: fix sidebar active status not working as expected (#140) (#149)
0b181e7
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kiaking kiaking

Labels
bug Something isn't working
Projects
No open projects
v1.0.0-alpha
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix sidebar active status not working as expected (#140) vuejs/vitepress
1 participant
@kiaking