Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): adjust the position of the curtain to avoid block sidebar #1816

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

CHOYSEN
Copy link
Contributor

@CHOYSEN CHOYSEN commented Jan 20, 2023

refs #1049 #1709

reproduction

https://vitepress.vuejs.org/guide/what-is-vitepress

try collapse the first item of sidebar

@brc-dd brc-dd merged commit 48f0b01 into vuejs:main Jan 20, 2023
@CHOYSEN
Copy link
Contributor Author

CHOYSEN commented Jan 20, 2023

After this change, maybe the shadow(background: linear-gradient(var(--vp-c-bg), transparent 70%)) can be apply in .curtain directly instead of the before element. Did i miss anything :)

.VPNavBar.has-sidebar .curtain::before {
display: block;
width: 100%;
height: 32px;
background: linear-gradient(var(--vp-c-bg), transparent 70%);
content: "";
}

@brc-dd
Copy link
Member

brc-dd commented Jan 20, 2023

/cc @kiaking

PS: if this 100% thing was intentional, then probably we can revert this and just add pointer-events none.

@kiaking
Copy link
Member

kiaking commented Jan 20, 2023

No, it wasn't! This was planned so all good 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2023
@CHOYSEN CHOYSEN deleted the fix/15 branch February 1, 2023 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants