fix: custom home page with setting logoLink leads to 404 page
#3271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tried this change and (while it fixes the logo navigation) page now reloads on every navigation (including inside the app), but weirdly only on Firefox (Chrome is fine). Any idea why Firefox may behave like that? And this only happen when deployed (not reproducing locally, even on build->preview). |
|
Actually, it happens on all browsers, just was more noticeable on Firefox. Hopefully, there is a better solution to this issue, as reloading the page on local navigation significantly affects UX. |
|
Nevermind, I've just messed the regex. The fix is working. Sorry for the noise. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temporary fix for #3264
We can circumvent this case in the
router, which is that when using a custom homepage andthemeConfig.logoLinkis set to that custom homepage, clicking on the logo does not try to load the vitepress-generated homepage, but instead jumps directly to the custom homepage.